Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264625AbUDVSii (ORCPT ); Thu, 22 Apr 2004 14:38:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264627AbUDVSii (ORCPT ); Thu, 22 Apr 2004 14:38:38 -0400 Received: from mx1.redhat.com ([66.187.233.31]:20458 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S264625AbUDVSig (ORCPT ); Thu, 22 Apr 2004 14:38:36 -0400 Date: Thu, 22 Apr 2004 11:36:45 -0700 From: "David S. Miller" To: Denis Vlasenko Cc: jmorris@redhat.com, jgarzik@pobox.com, linux-kernel@vger.kernel.org Subject: Re: Large inlines in include/linux/skbuff.h Message-Id: <20040422113645.19208a70.davem@redhat.com> In-Reply-To: <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua> References: <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 22 On Thu, 22 Apr 2004 17:56:46 +0300 Denis Vlasenko wrote: > On Thursday 22 April 2004 03:47, James Morris wrote: > > On Wed, 21 Apr 2004, Denis Vlasenko wrote: > > > What shall be done with this? I'll make patch to move locking functions > > > into net/core/skbuff.c unless there is some reason not to do it. > > > > How will these changes impact performance? I asked this last time you > > posted about inlines and didn't see any response. > > Hard to say. We will lose ~2% to extra call/return instructions > but will gain 40kb of icache space. He's asking you to test and quantify the performance changes that occur as a result of this patch, not to figure it out via calculations in your head :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/