Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264627AbUDVSnW (ORCPT ); Thu, 22 Apr 2004 14:43:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264632AbUDVSnW (ORCPT ); Thu, 22 Apr 2004 14:43:22 -0400 Received: from phoenix.infradead.org ([213.86.99.234]:56838 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S264627AbUDVSnU (ORCPT ); Thu, 22 Apr 2004 14:43:20 -0400 Date: Thu, 22 Apr 2004 19:43:16 +0100 (BST) From: James Simmons To: Jakub Bogusz cc: linux-kernel@vger.kernel.org, , Subject: Re: [PATCH 2.4, 2.6] rivafb 16bpp text background colour fix In-Reply-To: <20040422164101.GA16878@gruby.cs.net.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 36 I applied it to the newer Nvidia driver I have. I plan to o stream line in the next few weeks. On Thu, 22 Apr 2004, Jakub Bogusz wrote: > I sent it already to Ani Joshi long time ago (December 2002), > but it seems to be lost somewhere in time. > I noticed that Pawel Goleniowski made the same patch and sent to LKML > in December 2003 and January 2004: > http://www.uwsg.iu.edu/hypermail/linux/kernel/0312.2/1258.html > http://www.uwsg.iu.edu/hypermail/linux/kernel/0401.1/0225.html > but it's still not fixed. > > The same applies to 2.6.x series, only filename > (linux-2.6.*/drivers/video/riva/fbdev.c instead of .../riva/accel.c) > and whitespace (tabs are used now instead of spaces) differ. > > Original description (written in Dec 2002): > > I noticed, that text background in 16bpp (only) modes is displayed > > incorrectly. That's because convert_bgcolor_16() converts value to RGBA > > from 15bpp, not 16bpp. > > > > The fix is attached (works for me, tested by one more person). > > Patch was made against Linux 2.4.19, but should apply to 2.4.20 and > > 2.5.x without changes. > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/