Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261712AbUDWXaO (ORCPT ); Fri, 23 Apr 2004 19:30:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261718AbUDWXaN (ORCPT ); Fri, 23 Apr 2004 19:30:13 -0400 Received: from phoenix.infradead.org ([213.86.99.234]:13572 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S261712AbUDWXaJ (ORCPT ); Fri, 23 Apr 2004 19:30:09 -0400 Date: Sat, 24 Apr 2004 00:30:06 +0100 (BST) From: James Simmons To: Byron Stanoszek cc: marcelo@hera.kernel.org, Subject: Re: [2.4.26 Patch] Blue line in nVidia framebuffer (rivafb) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 40 Its in 2.6.X as well. Applied patch. On Wed, 14 Apr 2004, Byron Stanoszek wrote: > This patch fixes a regression since Linux 2.4.21. There is an off-by-one error > with the vertical-blank register in the riva framebuffer driver. The error > makes a persistent scan line (normally blue) appear on the top of the screen. > > Marcelo, please include this patch in the next -pre series. > > Thanks, > Byron > > > --- linux-2.4.26/drivers/video/riva/fbdev.bak Wed Apr 14 11:45:26 2004 > +++ linux-2.4.26/drivers/video/riva/fbdev.c Wed Apr 14 14:15:22 2004 > @@ -952,7 +952,7 @@ > newmode.crtc[0x12] = Set8Bits (vDisplay); > newmode.crtc[0x13] = ((width / 8) * ((bpp + 1) / 8)) & 0xFF; > newmode.crtc[0x15] = Set8Bits (vBlankStart); > - newmode.crtc[0x16] = Set8Bits (vBlankEnd); > + newmode.crtc[0x16] = Set8Bits (vBlankEnd + 1); > > newmode.ext.bpp = bpp; > newmode.ext.width = width; > > > > -- > Byron Stanoszek Ph: (330) 644-3059 > Systems Programmer Fax: (330) 644-8110 > Commercial Timesharing Inc. Email: byron@comtime.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/