Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261746AbUDWXnF (ORCPT ); Fri, 23 Apr 2004 19:43:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261785AbUDWXnF (ORCPT ); Fri, 23 Apr 2004 19:43:05 -0400 Received: from mx1.redhat.com ([66.187.233.31]:34457 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261746AbUDWXnC (ORCPT ); Fri, 23 Apr 2004 19:43:02 -0400 Date: Fri, 23 Apr 2004 16:42:26 -0700 From: "David S. Miller" To: Clay Haapala Cc: jmorris@redhat.com, Matt_Domsch@dell.com, B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/libcrc32c, revised 040419 Message-Id: <20040423164226.3d6fa2c3.davem@redhat.com> In-Reply-To: References: <200403302043.22938.bzolnier@elka.pw.edu.pl> <20040330192350.GB5149@lists.us.dell.com> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 20 On Mon, 19 Apr 2004 16:37:01 -0500 Clay Haapala wrote: > +#if __GNUC__ >= 3 /* 2.x has "attribute", but only 3.0 has "pure */ > +#define attribute(x) __attribute__(x) > +#else > +#define attribute(x) > +#endif I was about to apply your two patches, but then I noticed this thing. WHatever you may need this for exists in linux/compiler.h and if it doesn't you should add the necessary macro interfaces there. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/