Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264549AbUDZLtu (ORCPT ); Mon, 26 Apr 2004 07:49:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264551AbUDZLtu (ORCPT ); Mon, 26 Apr 2004 07:49:50 -0400 Received: from mail.tpgi.com.au ([203.12.160.100]:26313 "EHLO mail5.tpgi.com.au") by vger.kernel.org with ESMTP id S264549AbUDZLts (ORCPT ); Mon, 26 Apr 2004 07:49:48 -0400 Date: Mon, 26 Apr 2004 21:27:13 +1000 From: "Nigel Cunningham" To: "Herbert Xu" , "Roland Stigge" , 234976@bugs.debian.org Subject: Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work Cc: "Pavel Machek" , "Linux Kernel Mailing List" Reply-To: ncunningham@linuxmail.com References: <1080310299.2108.10.camel@atari.stigge.org> <20040326142617.GA291@elf.ucw.cz> <1080315725.2951.10.camel@atari.stigge.org> <20040326155315.GD291@elf.ucw.cz> <1080317555.12244.5.camel@atari.stigge.org> <20040326161717.GE291@elf.ucw.cz> <1080325072.2112.89.camel@atari.stigge.org> <20040426094834.GA4901@gondor.apana.org.au> <20040426104015.GA5772@gondor.apana.org.au> Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: In-Reply-To: <20040426104015.GA5772@gondor.apana.org.au> User-Agent: Opera M2/7.50 (Linux, build 663) X-TPG-Antivirus: Passed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 33 Hi. On Mon, 26 Apr 2004 20:40:15 +1000, Herbert Xu wrote: > On Mon, Apr 26, 2004 at 07:48:34PM +1000, herbert wrote: >> >> A simple solution is to copy the pages in reverse. This way the >> top page table is filled in last which should resolve this particular >> issue. The following patch does exactly that and fixes the problem >> for me. > > Of course this doesn't work for machines without PSE. But then the > original code didn't work either. Since resuming from 486's isn't > that cool anyway, IMHO someone should just add a PSE check in the > swsusp/pmdisk init code on i386. There used to be such a check. Centrinos, however, if I recall correctly, don't have PSE but can suspend with our current method. Perhaps we can come up with a more nuanced test? Better still, though, we should just get proper AGP support for suspending and resuming in. Nigel -- Nigel Cunningham C/- Westminster Presbyterian Church Belconnen 61 Templeton Street, Cook, ACT 2614, Australia. +61 (2) 6251 7727 (wk) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/