Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264409AbUD0X2I (ORCPT ); Tue, 27 Apr 2004 19:28:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264429AbUD0X2I (ORCPT ); Tue, 27 Apr 2004 19:28:08 -0400 Received: from mail.tpgi.com.au ([203.12.160.57]:6802 "EHLO mail1.tpgi.com.au") by vger.kernel.org with ESMTP id S264409AbUD0X2D (ORCPT ); Tue, 27 Apr 2004 19:28:03 -0400 Date: Wed, 28 Apr 2004 09:16:07 +1000 From: "Nigel Cunningham" To: "Pavel Machek" Subject: Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work Cc: "Herbert Xu" , "Andrew Morton" , seife@suse.de, "Benjamin Herrenschmidt" , "Nigel Cunningham" , "Roland Stigge" , 234976@bugs.debian.org, "Linux Kernel Mailing List" Reply-To: ncunningham@linuxmail.org References: <20040426104015.GA5772@gondor.apana.org.au> <20040426131152.GN2595@openzaurus.ucw.cz> <1083048985.12517.21.camel@gaston> <20040427102127.GB10593@elf.ucw.cz> <20040427102344.GA24313@gondor.apana.org.au> <20040427124837.GK10593@elf.ucw.cz> <20040427125402.GA16740@gondor.apana.org.au> <20040427215236.GA469@elf.ucw.cz> <20040427231626.GA32689@elf.ucw.cz> Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: In-Reply-To: <20040427231626.GA32689@elf.ucw.cz> User-Agent: Opera M2/7.50 (Linux, build 663) X-TPG-Antivirus: Passed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 46 Hi. On Wed, 28 Apr 2004 01:16:26 +0200, Pavel Machek wrote: > Hi! > >> On Tue, 27 Apr 2004 23:52:36 +0200, Pavel Machek wrote: >> >> >+#ifdef CONFIG_SOFTWARE_SUSPEND >> >+ { >> >+ extern char swsusp_pg_dir[PAGE_SIZE]; >> >+ memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE); >> >+ } >> >+#endif >> >> Would you consider making that #ifdef CONFIG_PM, so that I could use it >> too without needing to patch it further? (I'm using >> CONFIG_SOFTWARE_SUSPEND2 if you prefer something more specific). >> > > Well, swsusp_pg_dir is defined in kernel/power/cpu.c, so it is not as > easy as defining it CONFIG_PM. Ah. Of course. Humble apologies. > What about make CONFIG_SOFTWARE_SUSPEND2 defining > CONFIG_SOFTWARE_SUSPEND, too? We want the merged, anyway... Could do. And on the top of merging, sorry for the delays I'm getting there. I figured out yesterday what was holding me back with getting SMP & HighMem going under 2.6. It was really simple: the compile was using -O2. A quick change to the Makefile and I can now use a C file as I do with 2.4. Regards, Nigel -- Nigel Cunningham C/- Westminster Presbyterian Church Belconnen 61 Templeton Street, Cook, ACT 2614, Australia. +61 (2) 6251 7727 (wk) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/