Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264704AbUD1JQO (ORCPT ); Wed, 28 Apr 2004 05:16:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264708AbUD1JQO (ORCPT ); Wed, 28 Apr 2004 05:16:14 -0400 Received: from mail.native-instruments.de ([217.9.41.138]:47266 "EHLO mail.native-instruments.de") by vger.kernel.org with ESMTP id S264704AbUD1JQM (ORCPT ); Wed, 28 Apr 2004 05:16:12 -0400 Message-ID: <015701c42d01$70886260$9602010a@jingle> From: "Florian Schirmer" To: "Linus Torvalds" , Cc: "Kernel Mailing List" , References: Subject: Re: Linux 2.6.6-rc3 Date: Wed, 28 Apr 2004 11:16:07 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 38 Hi, > Armin Schindler: > o ISDN CAPI: add ncci list semaphore This looks broken for !CONFIG_ISDN_CAPI_MIDDLEWARE configs. Note the up() inside the #ifdef. @@ -904,13 +917,17 @@ if (copy_from_user((void *)&ncci, (void *)arg, sizeof(ncci))) return -EFAULT; - nccip = capincci_find(cdev, (u32) ncci); - if (!nccip) + + down(&cdev->ncci_list_sem); + if ((nccip = capincci_find(cdev, (u32) ncci)) == 0) { + up(&cdev->ncci_list_sem); return 0; + } #ifdef CONFIG_ISDN_CAPI_MIDDLEWARE if ((mp = nccip->minorp) != 0) { count += atomic_read(&mp->ttyopencount); } + up(&cdev->ncci_list_sem); #endif /* CONFIG_ISDN_CAPI_MIDDLEWARE */ return count; } Regards, Florian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/