Date: Wed, 28 Apr 2004 10:44:58 -0700
From: Greg KH <greg@kroah.com>
To: Michael_E_Brown@Dell.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] add SMBIOS tables to sysfs
Message-ID: <20040428174458.GH32040@kroah.com>
References: <0960978B185D2848BF5BBAE1BFB343E104F581@ausx2kmps315.aus.amer.dell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0960978B185D2848BF5BBAE1BFB343E104F581@ausx2kmps315.aus.amer.dell.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 29

On Wed, Apr 28, 2004 at 12:37:19PM -0500, Michael_E_Brown@Dell.com wrote:
> Looks good. You can go ahead and add it to your tree. 

Ok, will do, thanks for testing.

> I do have one question, though. Here:
> 
> > +static struct kobj_type ktype_smbios = {
> > +	.sysfs_ops	= &smbios_attr_ops,
> > +	.default_attrs	= def_attrs,
> > +	/* statically allocated, no release method necessary */
> > +};
> 
> I have no .release method because I have not kmalloc'ed any 
> instances of this struct. Do I need to re-add a release
> method here?

No, you are ok here.  Static kobj_type structures are ok for 2.6.  For
2.7 we will probably fix up all of this properly, we've learned a lot in
the past few years :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/