To: ken@coverity.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] Implementation inconsistencies in 2.6.3
References: <4448.171.64.70.113.1083102442.spork@webmail.coverity.com>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Wed, 28 Apr 2004 18:15:42 +0200
In-Reply-To: <4448.171.64.70.113.1083102442.spork@webmail.coverity.com> (Ken
 Ashcraft's message of "Tue, 27 Apr 2004 14:47:22 -0700 (PDT)")
Message-ID: <m3llkgnknl.fsf@defiant.pm.waw.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1361
Lines: 36

"Ken Ashcraft" <ken@coverity.com> writes:

/drivers/net/wan/hdlc_cisco.c:

> ---------------------------------------------------------
> [BUG] <khc@pm.waw.pl> not referencing 'dev'
>
> example:
> /home/kash/linux/2.6.3/linux-2.6.3/drivers/ieee1394/eth1394.c:569:ether1394_header:
> NOTE:READ: Checking arg dev [EXAMPLE=net_device.hard_header-1]
>
> /home/kash/linux/2.6.3/linux-2.6.3/drivers/net/wan/hdlc_cisco.c:37:cisco_hard_header:
> ERROR:READ: Not checking arg [COUNTER=net_device.hard_header-1]  [fit=62]
> [fit_fn=1] [fn_ex=0] [fn_counter=1] [ex=10] [counter=1] [z =
> -0.622543017479467] [fn-z = -4.35889894354067]
> #define CISCO_ADDR_REQ		0	/* Cisco address request */
> #define CISCO_ADDR_REPLY	1	/* Cisco address reply */
> #define CISCO_KEEPALIVE_REQ	2	/* Cisco keepalive request */
>
>
>
> Error --->
> static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
> 			     u16 type, void *daddr, void *saddr,
> 			     unsigned int len)
> {

False positive - while other hard_header functions may want to know
the actual outbound device, it isn't the case here.
-- 
Krzysztof Halasa, B*FH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/