Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263565AbUD2FaN (ORCPT ); Thu, 29 Apr 2004 01:30:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263568AbUD2FaN (ORCPT ); Thu, 29 Apr 2004 01:30:13 -0400 Received: from fw.osdl.org ([65.172.181.6]:9649 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S263565AbUD2FaK (ORCPT ); Thu, 29 Apr 2004 01:30:10 -0400 Date: Wed, 28 Apr 2004 22:29:50 -0700 From: Andrew Morton To: busterbcook@yahoo.com, linux-kernel@vger.kernel.org, Trond Myklebust Subject: Re: pdflush eating a lot of CPU on heavy NFS I/O Message-Id: <20040428222950.6406a9f0.akpm@osdl.org> In-Reply-To: <20040428214741.7d5b3ae1.akpm@osdl.org> References: <20040427230203.1e4693ac.akpm@osdl.org> <20040428124809.418e005d.akpm@osdl.org> <20040428182443.6747e34b.akpm@osdl.org> <20040428210214.31efe911.akpm@osdl.org> <20040428214741.7d5b3ae1.akpm@osdl.org> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 17 Andrew Morton wrote: > > Now, that redirtying of the inode _should_ have moved the inode off the > s_io list and onto the s_dirty list. But for some reason it looks like it > didn't, so we get stuck in a loop. I need to think about it a bit more. OK, it looks like nfs_writepages() might have been encountered the congested flag and it baled out without doing anything - the inode is still on the temporary s_io list, and no pages were redirtied, hence the inode wasn't redirtied, hence it remains stuck on the s_io list. The patch I sent will fix that up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/