Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261468AbUD3VpI (ORCPT ); Fri, 30 Apr 2004 17:45:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261479AbUD3VpH (ORCPT ); Fri, 30 Apr 2004 17:45:07 -0400 Received: from lists.us.dell.com ([143.166.224.162]:63688 "EHLO lists.us.dell.com") by vger.kernel.org with ESMTP id S261468AbUD3Vo7 (ORCPT ); Fri, 30 Apr 2004 17:44:59 -0400 Date: Fri, 30 Apr 2004 16:44:40 -0500 From: Matt Domsch To: Jens Axboe , akpm@osdl.org Cc: linux-kernel@vger.kernel.org Subject: Re: reduce blk queue and I/O capability printk to KERN_DEBUG? Message-ID: <20040430214440.GB9853@lists.us.dell.com> References: <20040430195055.GA7235@lists.us.dell.com> <20040430211342.GA31842@suse.de> <20040430212837.GA9853@lists.us.dell.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <20040430212837.GA9853@lists.us.dell.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2204 Lines: 76 --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 30, 2004 at 04:28:37PM -0500, Matt Domsch wrote: > On Fri, Apr 30, 2004 at 11:13:43PM +0200, Jens Axboe wrote: > > It should just be deleted. As you note, it is a debug message. I > > originally added it so we would have some clues as to dma capability for > > bug reports. There never was any, the check can go :) Second try, let's remove the unused variables. Please ack the below for Andrew then. Likewise for 2.4 please? Remove blk: queue xxxx I/O limit xxxx messages printed by all block devices This was a debug message and is no longer needed. =3D=3D=3D=3D=3D drivers/block/ll_rw_blk.c 1.244 vs edited =3D=3D=3D=3D=3D --- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004 +++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 16:38:52 2004 @@ -265,8 +265,6 @@ void blk_queue_bounce_limit(request_queue_t *q, u64 dma_addr) { unsigned long bounce_pfn =3D dma_addr >> PAGE_SHIFT; - unsigned long mb =3D dma_addr >> 20; - static request_queue_t *last_q; =20 /* * set appropriate bounce gfp mask -- unfortunately we don't have a @@ -280,19 +278,7 @@ } else q->bounce_gfp =3D GFP_NOIO; =20 - /* - * keep this for debugging for now... - */ - if (dma_addr !=3D BLK_BOUNCE_HIGH && q !=3D last_q) { - printk("blk: queue %p, ", q); - if (dma_addr =3D=3D BLK_BOUNCE_ANY) - printk("no I/O memory limit\n"); - else - printk("I/O limit %luMb (mask 0x%Lx)\n", mb, (long long) dma_addr); - } - q->bounce_pfn =3D bounce_pfn; - last_q =3D q; } =20 EXPORT_SYMBOL(blk_queue_bounce_limit); --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAksjIIavu95Lw/AkRAljhAJ90Uzt5vUtglUL52eV+UCDqsZfJmACfcO15 3BoD7rZfg387CdF3laIfLjs= =Tsah -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/