Date: Fri, 30 Apr 2004 16:40:39 -0700 (PDT)
From: Junfeng Yang <yjf@stanford.edu>
To: Dave Kleikamp <shaggy@austin.ibm.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       <jfs-discussion@www-124.southbury.usf.ibm.com>,
       Madanlal S Musuvathi <madan@stanford.edu>,
       "David L. Dill" <dill@cs.stanford.edu>
Subject: [CHECKER] Kernel panic when diWrite fails to get a page
Message-ID: <Pine.GSO.4.44.0404301638500.14945-100000@elaine24.Stanford.EDU>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1313
Lines: 61


txCommit calls diWrite, which can fail (diWrite -> read_metapage ->
read_cache_page).  txAbortCommit will be called in that case.  Kernel will
panic in LogSyncRelease on assert(log) because the "lo"g fields for some
metapages are NULL.  If we are going to kernel panic anyway, we should
panic at the first place without doing all these works to abort a
transcation.


int diWrite(tid_t tid, struct inode *ip)
{
	...
      retry:
	mp = read_metapage(ipimap, pageno << sbi->l2nbperpage, PSIZE, 1);
	if (mp == 0)
Fail -->	return -EIO;
	...
}

static void txAbortCommit(struct commit * cd)
{
	...
			if (mp->xflag & COMMIT_PAGE)
-->				LogSgyncRelease(mp);
	...
}


static void LogSyncRelease(struct metapage * mp)
{
	struct jfs_log *log = mp->log;

	assert(atomic_read(&mp->nohomeok));
Panic -->
	assert(log);
	atomic_dec(&mp->nohomeok);

	if (atomic_read(&mp->nohomeok))
		return;

	hold_metapage(mp, 0);

	LOGSYNC_LOCK(log);
	mp->log = NULL;
	mp->lsn = 0;
	mp->clsn = 0;
	log->count--;
	list_del_init(&mp->synclist);
	LOGSYNC_UNLOCK(log);

	release_metapage(mp);
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/