Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264968AbUFAJzf (ORCPT ); Tue, 1 Jun 2004 05:55:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264970AbUFAJzf (ORCPT ); Tue, 1 Jun 2004 05:55:35 -0400 Received: from mail.ocs.com.au ([202.147.117.210]:33219 "EHLO mail.ocs.com.au") by vger.kernel.org with ESMTP id S264968AbUFAJza (ORCPT ); Tue, 1 Jun 2004 05:55:30 -0400 X-Mailer: exmh version 2.6.3_20040314 03/14/2004 with nmh-1.0.4 From: Keith Owens To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [patch 2.6.7-rc2] Add const to some scheduling functions In-reply-to: Your message of "Tue, 01 Jun 2004 00:16:32 MST." <20040601001632.1cc185ba.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 01 Jun 2004 19:55:24 +1000 Message-ID: <12672.1086083724@ocs3.ocs.com.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 18 On Tue, 1 Jun 2004 00:16:32 -0700, Andrew Morton wrote: >Keith Owens wrote: >> >> Several scheduler macros only read from the task struct, mark them >> const. It can generate better code. > >It makes no change to the gcc-3.4.0-compiled x86 kernel's size. Under what >circumstances did you see improvements? None, it is just good programming practice to mark parameters as const where possible. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/