Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265008AbUFAMLP (ORCPT ); Tue, 1 Jun 2004 08:11:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265009AbUFAMLO (ORCPT ); Tue, 1 Jun 2004 08:11:14 -0400 Received: from mtagate3.de.ibm.com ([195.212.29.152]:33228 "EHLO mtagate3.de.ibm.com") by vger.kernel.org with ESMTP id S265008AbUFAMLE convert rfc822-to-8bit (ORCPT ); Tue, 1 Jun 2004 08:11:04 -0400 Subject: Re: [PATCH] ppc64: Fix possible race with set_pte on a present PTE To: Benjamin Herrenschmidt Cc: Andrew Morton , Andrea Arcangeli , bcrl@kvack.org, "David S. Miller" , Linux Arch list , Linux Kernel list , linux-mm@kvack.org, mingo@elte.hu, Linus Torvalds , wesolows@foobazco.org, willy@debian.org X-Mailer: Lotus Notes Release 5.0.11 July 24, 2002 Message-ID: From: Martin Schwidefsky Date: Tue, 1 Jun 2004 14:10:53 +0200 X-MIMETrack: Serialize by Router on D12ML062/12/M/IBM(Release 6.0.2CF2|July 23, 2003) at 01/06/2004 14:10:41 MIME-Version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 29 > I did the ppc64 impl, the x86 one (hope I got it right). I still need to > do ppc32 and I suppose s390 must be fixed now that ptep_estabish is gone > but I'll leave that to someone who understand something about these things ;) At the moment I can't access linux.bkbits.net so I can't test anything but as far as I can tell s390 should just work as is. ptep_establish is gone but it has been replaced by correct sequences: ptep_clear_flush & set_pte and set_pte & flush_tlb_page. The second sequence can be optimized to a ptep_clear_flush & set_pte if the _PAGE_RO bit has changed. Apart from that s390 is perfectly fine with the change. blue skies, Martin Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH Sch?naicherstr. 220, D-71032 B?blingen, Telefon: 49 - (0)7031 - 16-2247 E-Mail: schwidefsky@de.ibm.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/