Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265135AbUFARJQ (ORCPT ); Tue, 1 Jun 2004 13:09:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265132AbUFARJQ (ORCPT ); Tue, 1 Jun 2004 13:09:16 -0400 Received: from ozlabs.org ([203.10.76.45]:23207 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S265128AbUFARJN (ORCPT ); Tue, 1 Jun 2004 13:09:13 -0400 Date: Wed, 2 Jun 2004 03:04:18 +1000 From: Anton Blanchard To: Andi Kleen Cc: "David S. Miller" , linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: compat syscall args Message-ID: <20040601170418.GA4239@krispykreme> References: <21hGW-h5-5@gated-at.bofh.it> <229Hi-B1-11@gated-at.bofh.it> <22drH-3Bc-47@gated-at.bofh.it> <22dL7-3O8-39@gated-at.bofh.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 17 > It would be better to do this consistently over all architectures > and do the sign extension (which is much less common than zero > extension) always in C code. Then when someone adds a new compat > handler the chances are high that it will just work over multiple > architectures (ok minus s390) without much more changes. On ppc64 we now zero extend all arguments. I too would like to see the sign extension done in the common compat code, at the moment we have to be careful to do it before calling compat code. Anton - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/