Date: Wed, 2 Jun 2004 00:36:26 -0700
From: Andrew Morton <akpm@osdl.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, bilotta78@hotpop.com,
       danlee@informatik.uni-freiburg.de, vojtech@suse.cz, tuukkat@ee.oulu.fi
Subject: Re: [RFC/RFT] Raw access to serio ports (1/2)
Message-Id: <20040602003626.4d754944.akpm@osdl.org>
In-Reply-To: <200406020218.42979.dtor_core@ameritech.net>
References: <200406020218.42979.dtor_core@ameritech.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 41

Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> Hi,
> 
> Below is an implementation of rawdev driver.

Yes, it does appear that we need the feature, thanks.

> Comments?

They're the thingies inside /* and */.  Your patch is refreshingly free of
them ;)

> +static ssize_t rawdev_write(struct file *file, const char *buffer, size_t count, loff_t *ppos)
> +{
> +	struct rawdev_list *list = file->private_data;
> +	ssize_t written = 0;
> +	int retval;
> +	unsigned char c;
> +
> +	retval = down_interruptible(&rawdev_sem);
> +	if (retval)
> +		return retval;
> +
> +	if (!list->rawdev->serio) {
> +		retval = -ENODEV;
> +		goto out;
> +	}

The return values here are mucked up - this function returns `written'.

> +	if (count > 32)
> +		count = 32;

Why?  (Don't tell me - add a comment!)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/