Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263226AbUFBPM7 (ORCPT ); Wed, 2 Jun 2004 11:12:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263191AbUFBPM7 (ORCPT ); Wed, 2 Jun 2004 11:12:59 -0400 Received: from fw.osdl.org ([65.172.181.6]:428 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S263184AbUFBPMl (ORCPT ); Wed, 2 Jun 2004 11:12:41 -0400 Date: Wed, 2 Jun 2004 08:12:00 -0700 (PDT) From: Linus Torvalds To: =?iso-8859-1?Q?J=F6rn?= Engel cc: Horst von Brand , Pavel Machek , Andrew Morton , Arjan van de Ven , Ingo Molnar , Andrea Arcangeli , Rik van Riel , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] explicitly mark recursion count In-Reply-To: <20040602150440.GA26474@wohnheim.fh-wedel.de> Message-ID: References: <200406011929.i51JTjGO006174@eeyore.valparaiso.cl> <20040602131623.GA23017@wohnheim.fh-wedel.de> <20040602142748.GA25939@wohnheim.fh-wedel.de> <20040602150440.GA26474@wohnheim.fh-wedel.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 30 On Wed, 2 Jun 2004, J?rn Engel wrote: > > Can I read this as: > Linus himself will use strong words to enforce all recursions in the > kernel to be either removed or properly documented. If we have a good detector that is reliable and easy to run, why not? It will take some time, but I think the problem so far has been that the recursion can be hard to see. Some "core" cases are well-known (memory allocations during memory allocation, and filename lookup), and they should be trivial to annotate. Knock wood. Others might be worse. > In that case, you have 273 recursions to deal with. They are all in > the data I attached a few posts back. Recursions would basically be > in the same league as huge stack hogs, sounds good. Yes. And with huge stack hogs, we've not exactly "fixed them all in a weekend", have we? But having a few people run the checking tools and nagging every once in a while ends up eventually fixing things. At least the most common ones. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/