Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263741AbUFBRe4 (ORCPT ); Wed, 2 Jun 2004 13:34:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263718AbUFBRey (ORCPT ); Wed, 2 Jun 2004 13:34:54 -0400 Received: from mail.kroah.org ([65.200.24.183]:50397 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S263766AbUFBRe1 (ORCPT ); Wed, 2 Jun 2004 13:34:27 -0400 Date: Wed, 2 Jun 2004 10:32:00 -0700 From: Greg KH To: J?rn Engel Cc: Linus Torvalds , Horst von Brand , Pavel Machek , Andrew Morton , Arjan van de Ven , Ingo Molnar , Andrea Arcangeli , Rik van Riel , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] explicitly mark recursion count Message-ID: <20040602173200.GA12254@kroah.com> References: <20040602142748.GA25939@wohnheim.fh-wedel.de> <20040602150440.GA26474@wohnheim.fh-wedel.de> <20040602152741.GC26474@wohnheim.fh-wedel.de> <20040602161721.GA29296@wohnheim.fh-wedel.de> <20040602171732.GA30427@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040602171732.GA30427@wohnheim.fh-wedel.de> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 34 On Wed, Jun 02, 2004 at 07:17:32PM +0200, J?rn Engel wrote: > > Leaves usb_audio_recurseunit() as the only function in question, that > one could actually be sane, although it looks rather interesting: > WARNING: trivial recursion detected: > 0 usb_audio_recurseunit > WARNING: recursion detected: > 16 usb_audio_selectorunit > 0 usb_audio_recurseunit > WARNING: multiple recursions around usb_audio_recurseunit() > WARNING: recursion detected: > 0 usb_audio_recurseunit > 0 usb_audio_processingunit > > Greg, can you say whether this construct makes sense? Well it's sane only if you think that USB descriptors can be sane :) Anyway, this loop will always terminate as we have a finite sized USB descriptor that this function is parsing. As to how many times we will recurse, I don't really know as I haven't spent much time looking into the different messed up USB audio devices out there on the market... Sorry I can't be of more help, but I don't think you need to worry about this function. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/