Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263735AbUFBRr7 (ORCPT ); Wed, 2 Jun 2004 13:47:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263752AbUFBRr7 (ORCPT ); Wed, 2 Jun 2004 13:47:59 -0400 Received: from mail.fh-wedel.de ([213.39.232.194]:38296 "EHLO mail.fh-wedel.de") by vger.kernel.org with ESMTP id S263735AbUFBRrz (ORCPT ); Wed, 2 Jun 2004 13:47:55 -0400 Date: Wed, 2 Jun 2004 19:46:53 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Greg KH Cc: Linus Torvalds , Horst von Brand , Pavel Machek , Andrew Morton , Arjan van de Ven , Ingo Molnar , Andrea Arcangeli , Rik van Riel , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] explicitly mark recursion count Message-ID: <20040602174653.GB30427@wohnheim.fh-wedel.de> References: <20040602142748.GA25939@wohnheim.fh-wedel.de> <20040602150440.GA26474@wohnheim.fh-wedel.de> <20040602152741.GC26474@wohnheim.fh-wedel.de> <20040602161721.GA29296@wohnheim.fh-wedel.de> <20040602171732.GA30427@wohnheim.fh-wedel.de> <20040602173200.GA12254@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20040602173200.GA12254@kroah.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 45 On Wed, 2 June 2004 10:32:00 -0700, Greg KH wrote: > On Wed, Jun 02, 2004 at 07:17:32PM +0200, J?rn Engel wrote: > > > > Leaves usb_audio_recurseunit() as the only function in question, that > > one could actually be sane, although it looks rather interesting: > > WARNING: trivial recursion detected: > > 0 usb_audio_recurseunit > > WARNING: recursion detected: > > 16 usb_audio_selectorunit > > 0 usb_audio_recurseunit > > WARNING: multiple recursions around usb_audio_recurseunit() > > WARNING: recursion detected: > > 0 usb_audio_recurseunit > > 0 usb_audio_processingunit > > > > Greg, can you say whether this construct makes sense? > > Well it's sane only if you think that USB descriptors can be sane :) > > Anyway, this loop will always terminate as we have a finite sized USB > descriptor that this function is parsing. As to how many times we will > recurse, I don't really know as I haven't spent much time looking into > the different messed up USB audio devices out there on the market... > > Sorry I can't be of more help, but I don't think you need to worry about > this function. That's ok. At least you can talk about that code without obvious disgust, which is a quality criterium in itself. Leaves exactly one multiply recursive function we might want to keep. So I just won't worry too much and ignore the warnings about it, fine. J?rn -- ticks = jiffies; while (ticks == jiffies); ticks = jiffies; -- /usr/src/linux/init/main.c - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/