Message-ID: <40BE6CA9.9030403@zytor.com>
Date: Wed, 02 Jun 2004 17:11:21 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.6) Gecko/20040510
MIME-Version: 1.0
To: Hanna Linder <hannal@us.ibm.com>
CC: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 2.6.6-rc2 RFT] Add's class support to cpuid.c
References: <98460000.1086215543@dyn318071bld.beaverton.ibm.com>
In-Reply-To: <98460000.1086215543@dyn318071bld.beaverton.ibm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1019
Lines: 31

Hanna Linder wrote:
> This patch adds class support to arch/i386/kernel/cpuid.c. This enables udev
> support. I have tested on a 2-way SMP system and on a 2-way built as UP.
> Here are the results for the SMP:

I think it would be better if udev could handle /dev/cpu as an iterator 
instead of needing O(N) kernel memory for all per-CPU devices; I made the same 
comments about devfs.

As it is, it also mishandles the hotswap CPU scenario.

> [hlinder@w-hlinder2 hlinder]$ tree /sys/class/cpuid
> /sys/class/cpuid
> |-- cpu0
> |   `-- dev
> `-- cpu1
>     `-- dev
> 
> 2 directories, 2 files
> [hlinder@w-hlinder2 hlinder]$ more /sys/class/cpuid/cpu0/dev
> 203:0
> [hlinder@w-hlinder2 hlinder]$ more /sys/class/cpuid/cpu1/dev
> 203:1
> [hlinder@w-hlinder2 hlinder]$

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/