Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261932AbUFCNY1 (ORCPT ); Thu, 3 Jun 2004 09:24:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262071AbUFCNY1 (ORCPT ); Thu, 3 Jun 2004 09:24:27 -0400 Received: from aun.it.uu.se ([130.238.12.36]:65019 "EHLO aun.it.uu.se") by vger.kernel.org with ESMTP id S261932AbUFCNY0 (ORCPT ); Thu, 3 Jun 2004 09:24:26 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16575.9858.655475.206533@alkaid.it.uu.se> Date: Thu, 3 Jun 2004 15:24:18 +0200 From: Mikael Pettersson To: Joshua Kwan Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.7-rc2-mm1 In-Reply-To: References: <20040601021539.413a7ad7.akpm@osdl.org> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 27 Joshua Kwan writes: > On Tue, 01 Jun 2004 02:15:39 -0700, Andrew Morton wrote: > > - merged perfctr. No documentation though :( > > In light of all of the problems with perfctr here, I've gone and done the > ifdef work for CONFIG_PERFCTR, presenting an alternative solution to the > struct problem... > > http://triplehelix.org/~joshk/perfctr.diff What "all the problems"? There was an issue with warnings on struct-declared-in-parameter-list when CONFIG_PERFCTR is disabled, but those are trivial to fix and a fix was posted early on. Your patch is #ifdef:ing out calls that have explicit no-op stubs for the !CONFIG_PERFCTR_VIRTUAL case. This shouldn't be needed. (And you're testing the wrong config option.) Also _please_ include the maintainer of said code if you think it has problems. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/