Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263736AbUFCUBz (ORCPT ); Thu, 3 Jun 2004 16:01:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264205AbUFCUBy (ORCPT ); Thu, 3 Jun 2004 16:01:54 -0400 Received: from vsmtp14.tin.it ([212.216.176.118]:65258 "EHLO vsmtp14.tin.it") by vger.kernel.org with ESMTP id S263736AbUFCUBx (ORCPT ); Thu, 3 Jun 2004 16:01:53 -0400 Message-ID: <40BF83AD.1020401@stanchina.net> Date: Thu, 03 Jun 2004 22:01:49 +0200 From: Flavio Stanchina User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040401 Debian/1.6-4 X-Accept-Language: en MIME-Version: 1.0 To: Peter Osterlund CC: Linus Torvalds , Kernel Mailing List , Andrew Morton , trond.myklebust@fys.uio.no Subject: Re: Linux 2.6.7-rc2 References: In-Reply-To: X-Enigmail-Version: 0.83.6.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 21 Peter Osterlund wrote: > [patch to linux/fs/nfs/read.c] > + memset(rdata, 0, sizeof(*rdata)); > + rdata->flags = (IS_SWAPFILE(inode)? NFS_RPC_SWAPFLAGS : 0); Wouldn't this be better as: if (IS_SWAPFILE(inode)) rdata->flags = NFS_RPC_SWAPFLAGS; > + rdata->args.pgbase = 0UL; Wouldn't this be redundant? -- Ciao, Flavio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/