Date: Fri, 4 Jun 2004 12:01:46 -0700
From: Paul Jackson <pj@sgi.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: mikpe@csd.uu.se, nickpiggin@yahoo.com.au, rusty@rustcorp.com.au,
       linux-kernel@vger.kernel.org, akpm@osdl.org, ak@muc.de,
       ashok.raj@intel.com, hch@infradead.org, jbarnes@sgi.com,
       joe.korty@ccur.com, manfred@colorfullife.com, colpatch@us.ibm.com,
       Simon.Derr@bull.net
Subject: Re: [PATCH] cpumask 5/10 rewrite cpumask.h - single bitmap based
 implementation
Message-Id: <20040604120146.4d28116a.pj@sgi.com>
In-Reply-To: <20040604175255.GD21007@holomorphy.com>
References: <20040603094339.03ddfd42.pj@sgi.com>
	<20040603101010.4b15734a.pj@sgi.com>
	<1086313667.29381.897.camel@bach>
	<40BFD839.7060101@yahoo.com.au>
	<20040603221854.25d80f5a.pj@sgi.com>
	<16576.16748.771295.988065@alkaid.it.uu.se>
	<20040604090314.56d64f4d.pj@sgi.com>
	<20040604165601.GC21007@holomorphy.com>
	<20040604102946.1d501953.pj@sgi.com>
	<20040604175255.GD21007@holomorphy.com>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1134
Lines: 28

William Lee Irwin III wrote:
> +void bitmap_to_u32_array(u32 *dst, unsigned long *src, int nwords)

Good.

Assuming that you're signing up to push this baby along ...

Would it be better to remove the ENDIAN specific ifdefs from
lib/bitmap.c, and instead add something like the BIT32X() macro I
described earlier on this thread, in an aside to Mikael Pettersson?
If that macro were defined right in the ./linux/byteorder/*_endian.h
files, then endian neutral code could be put in lib/bitmap.c, and
endian aware code kept in the endian.h files.

Could you extend the cpumask_t API with a corresponding routine?

Mikael - does William's routine look like the makings of something
that fits your needs?

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/