Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264088AbUFFTqr (ORCPT ); Sun, 6 Jun 2004 15:46:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264085AbUFFTqr (ORCPT ); Sun, 6 Jun 2004 15:46:47 -0400 Received: from gprs214-14.eurotel.cz ([160.218.214.14]:34177 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S264090AbUFFTqk (ORCPT ); Sun, 6 Jun 2004 15:46:40 -0400 Date: Sun, 6 Jun 2004 21:46:29 +0200 From: Pavel Machek To: Dominik Brodowski , john stultz , lkml , george anzinger , greg kh , Chris McDermott Subject: Re: Too much error in __const_udelay() ? Message-ID: <20040606194629.GB10081@elf.ucw.cz> References: <1086419565.2234.133.camel@cog.beaverton.ibm.com> <20040605152326.GA11239@dominikbrodowski.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040605152326.GA11239@dominikbrodowski.de> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 21 Hi! > Change 3: > > Asserting at least 1 loop is spent: in really small ndelay() calls to > low-mhz timers, this might be better. > > return __delay(xloops ? xloops : 1); Should not you always round up? If user asks you to delay 1900 usec, delaying 1000 usec is a bug. If you do this, make-it-one-when-its-zero hack should be unneccessary. Pavel -- 934a471f20d6580d5aad759bf0d97ddc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/