Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264312AbUFGHYZ (ORCPT ); Mon, 7 Jun 2004 03:24:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264337AbUFGHYZ (ORCPT ); Mon, 7 Jun 2004 03:24:25 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:925 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S264312AbUFGHYW (ORCPT ); Mon, 7 Jun 2004 03:24:22 -0400 Date: Mon, 7 Jun 2004 09:24:15 +0200 From: Jens Axboe To: Con Kolivas Cc: Pascal Schmidt , Linux Kernel Mailinglist Subject: Re: [OT] Who has record no. of DriveReady SeekComplete DataRequest errors? Message-ID: <20040607072414.GC13836@suse.de> References: <200406060007.10150.kernel@kolivas.org> <20040606203942.GA20267@suse.de> <200406070906.46392.kernel@kolivas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406070906.46392.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2748 Lines: 73 On Mon, Jun 07 2004, Con Kolivas wrote: > On Mon, 7 Jun 2004 06:39, Jens Axboe wrote: > > I could easily imagine some vendors not setting the field, but setting > > it to some "buggy" value is far less likely. But might as well add the > > check. > > > > Con later confirmed that it was 2.6.2 that introduced the breakage, so > > the patch isn't the culprit after all. There are a few seperate things > > to look at there - Con, what are you doing when these messages trigger? > > Is the drive permanently mounted, or does it happen on open? > > It only happens on boot and never again. During this part: > ICH4: IDE controller at PCI slot 0000:00:1f.1 > ICH4: chipset revision 2 > ICH4: not 100% native mode: will probe irqs later > ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:DMA, hdb:DMA > ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:DMA, hdd:DMA > hda: ST340014A, ATA DISK drive > hdb: ST340014A, ATA DISK drive > ide0 at 0x1f0-0x1f7,0x3f6 on irq 14 > hdc: JLMS XJ-HD165H, ATAPI CD/DVD-ROM drive > hdd: RICOH CD-R/RW MP7163A, ATAPI CD/DVD-ROM drive > ide1 at 0x170-0x177,0x376 on irq 15 > hda: max request size: 1024KiB > hda: 78165360 sectors (40020 MB) w/2048KiB Cache, CHS=16383/255/63, UDMA(100) > hda: hda1 hda2 < hda5 hda6 hda7 > > hdb: max request size: 1024KiB > hdb: 78165360 sectors (40020 MB) w/2048KiB Cache, CHS=16383/255/63, UDMA(100) > hdb: hdb2 < hdb5 hdb6 hdb7 > > hdc: ATAPI 48X DVD-ROM drive, 512kB Cache, UDMA(33) > Uniform CD-ROM driver Revision: 3.20 > hdd: status error: status=0x59 { DriveReady SeekComplete DataRequest Error } > hdd: status error: error=0x20LastFailedSense 0x02 > hdd: drive not ready for command > hdd: status error: status=0x58 { DriveReady SeekComplete DataRequest } > hdd: status error: error=0x00 > ..etc > > I'll try that other patch when I get a chance later today. (which didn't make a difference, oddly. it's about the only thing changed at module load time). Con, please try with this debug patch. ===== drivers/ide/ide-cd.c 1.83 vs edited ===== --- 1.83/drivers/ide/ide-cd.c 2004-05-29 19:04:42 +02:00 +++ edited/drivers/ide/ide-cd.c 2004-06-07 09:23:41 +02:00 @@ -1548,9 +1548,14 @@ /* Start of retry loop. */ do { - int error; + int error, i; unsigned long time = jiffies; rq->flags = flags; + + printk("ide-cd: queueing cdb: "); + for (i = 0; i < 12; i++) + printk("%02x ", rq->cmd[i]); + printk("\n"); error = ide_do_drive_cmd(drive, rq, ide_wait); time = jiffies - time; -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/