Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264653AbUFGOJs (ORCPT ); Mon, 7 Jun 2004 10:09:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264659AbUFGOJs (ORCPT ); Mon, 7 Jun 2004 10:09:48 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:51133 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S264653AbUFGOFy (ORCPT ); Mon, 7 Jun 2004 10:05:54 -0400 Message-ID: <40C47635.4090302@pobox.com> Date: Mon, 07 Jun 2004 10:05:41 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Takashi Iwai CC: linux-kernel@vger.kernel.org, viro@parcelfarce.linux.theplanet.co.uk, perex@suse.cz, torvalds@osdl.org Subject: Re: [RFC] ASLA design, depth of code review and lack thereof References: <20040604230819.GR12308@parcelfarce.linux.theplanet.co.uk> <40C107D2.9030301@pobox.com> <40C471FC.3000802@pobox.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 21 Takashi Iwai wrote: > They're nice but they don't provide "cast checking", no? > The main purpose of the magic_* stuffs in ALSA is to check the cast of > the void pointer back to the original data type, which the compiler > can't check. Sure -- and that magic cast stuff is horribly bloated, and not needed in good code. No other code in Linux does this -- therefore it should be removed. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/