Date: Mon, 07 Jun 2004 16:12:54 +0200
Message-ID: <s5h65a34ftl.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, viro@parcelfarce.linux.theplanet.co.uk,
       perex@suse.cz, torvalds@osdl.org
Subject: Re: [RFC] ASLA design, depth of code review and lack thereof
In-Reply-To: <40C47635.4090302@pobox.com>
References: <20040604230819.GR12308@parcelfarce.linux.theplanet.co.uk>
	<40C107D2.9030301@pobox.com>
	<s5hekor4i2c.wl@alsa2.suse.de>
	<40C471FC.3000802@pobox.com>
	<s5h7juj4gio.wl@alsa2.suse.de>
	<40C47635.4090302@pobox.com>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 917
Lines: 28

At Mon, 07 Jun 2004 10:05:41 -0400,
Jeff Garzik wrote:
> 
> Takashi Iwai wrote:
> > They're nice but they don't provide "cast checking", no?
> > The main purpose of the magic_* stuffs in ALSA is to check the cast of
> > the void pointer back to the original data type, which the compiler
> > can't check.
> 
> Sure -- and that magic cast stuff is horribly bloated, and not needed in 
> good code.

A good code needs never debugging stuffs :)

I agree that the current ALSA's magic stuff is much bigger than
needed, though.

> No other code in Linux does this -- therefore it should be removed.

Hmm?  The magic check itself is found in many linux driver codes...


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/