Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265047AbUFGUmH (ORCPT ); Mon, 7 Jun 2004 16:42:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265044AbUFGUmG (ORCPT ); Mon, 7 Jun 2004 16:42:06 -0400 Received: from [213.146.154.40] ([213.146.154.40]:23511 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S265047AbUFGUln (ORCPT ); Mon, 7 Jun 2004 16:41:43 -0400 Date: Mon, 7 Jun 2004 21:41:42 +0100 From: Christoph Hellwig To: Linus Torvalds Cc: Kernel Mailing List Subject: Re: Linux 2.6.7-rc3 Message-ID: <20040607204142.GA26986@infradead.org> Mail-Followup-To: Christoph Hellwig , Linus Torvalds , Kernel Mailing List References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 36 On Mon, Jun 07, 2004 at 12:32:45PM -0700, Linus Torvalds wrote: > > Ok, let's calm down for a while before the final 2.6.7. > > -rc3 does a lot of sparse type cleanup, mainly thanks to Al Viro (but his > work ended up getting some other people involved too, since the list of > sparse warnings isn't as daunting any more). Some of that has unearthed > real bugs which Al fixed. > > But there are DRM, AGP, cpufreq, sparc64, and input updates there too. See > the appended shortlog for more details, This one here: diff -Nru a/include/linux/netfilter_arp.h b/include/linux/netfilter_arp.h --- a/include/linux/netfilter_arp.h 2004-06-07 21:58:09 +02:00 +++ b/include/linux/netfilter_arp.h 2004-06-07 21:58:09 +02:00 @@ -17,4 +17,5 @@ #define NF_ARP_FORWARD 2 #define NF_ARP_NUMHOOKS 3 +static DECLARE_MUTEX(arpt_mutex); #endif /* __LINUX_ARP_NETFILTER_H */ looks perfectly fucked up. This way every file including netfilter_arp.h will get it's own copy of arpt_mutex which certainly doesn't help synchronization. But in fact I can only see a single file actually using it, that's arp_tables.c where it was defined previously. What's going on here? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/