Message-ID: <40C61A20.4000906@kolumbus.fi>
Date: Tue, 08 Jun 2004 22:57:20 +0300
From: =?ISO-8859-15?Q?Mika_Penttil=E4?= <mika.penttila@kolumbus.fi>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1
MIME-Version: 1.0
To: Chris Mason <mason@suse.com>
CC: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback_inodes can race with unmount
References: <1086722523.10973.157.camel@watt.suse.com>
In-Reply-To: <1086722523.10973.157.camel@watt.suse.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1706
Lines: 52


Chris Mason wrote:

>There's a small window where the filesystem can be unmounted during
>writeback_inodes.  The end result is the iput done by sync_sb_inodes
>could be done after the FS put_super and and the super has been removed
>from all lists.
>  
>

Why don't we have the same race in the sync() path as well? Moving the 
locking to sync_sb_inodes() itself would fix it also.

>The fix is to hold the s_umount sem during sync_sb_inodes to make sure
>the FS doesn't get unmounted.
>
>Index: linux.t/fs/fs-writeback.c
>===================================================================
>--- linux.t.orig/fs/fs-writeback.c	2004-06-08 14:45:49.000000000 -0400
>+++ linux.t/fs/fs-writeback.c	2004-06-08 14:47:58.000000000 -0400
>@@ -360,9 +360,18 @@ restart:
> 	sb = sb_entry(super_blocks.prev);
> 	for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.prev)) {
> 		if (!list_empty(&sb->s_dirty) || !list_empty(&sb->s_io)) {
>+			/* we're making our own get_super here */
> 			sb->s_count++;
> 			spin_unlock(&sb_lock);
>-			sync_sb_inodes(sb, wbc);
>+			/* if we can't get the readlock, there's no sense in
>+			 * waiting around, most of the time the FS is going
>+			 * to be unmounted by the time it is released
>+			 */
>+			if (down_read_trylock(&sb->s_umount)) {
>+				if (sb->s_root)
>+					sync_sb_inodes(sb, wbc);
>+				up_read(&sb->s_umount);
>+			}
> 			spin_lock(&sb_lock);
> 			if (__put_super(sb))
> 				goto restart;
>  
>

--Mika


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/