Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265722AbUFIJDS (ORCPT ); Wed, 9 Jun 2004 05:03:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265719AbUFIJDS (ORCPT ); Wed, 9 Jun 2004 05:03:18 -0400 Received: from cantor.suse.de ([195.135.220.2]:29139 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S265722AbUFIJDN (ORCPT ); Wed, 9 Jun 2004 05:03:13 -0400 Date: Wed, 09 Jun 2004 11:03:12 +0200 Message-ID: From: Takashi Iwai To: Pekka J Enberg Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] ALSA: Remove subsystem-specific malloc (0/8) In-Reply-To: References: <200406082124.i58LOrMm016152@melkki.cs.helsinki.fi> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 32 At Wed, 09 Jun 2004 10:57:45 +0200, I wrote: > > At Wed, 9 Jun 2004 00:24:53 +0300, > Pekka J Enberg wrote: > > > > This patch introduces a kcalloc() and replaces ALSA magic allocator > > snd_kcalloc() and snd_magic_kcalloc() with it. I also fixed a memory > > leak in the arm sa11xx driver and added a BUG() in seq_oss_synth to > > catch failing allocations. > > > > I kept the snd_magic_cast macro in place just in case someone wants to > > add a generic type checking facility in the kernel and convert the users > > to use it. > > > > The patch is against 2.6.6 and was compile-tested with allyesconfig. > > no, this patch breaks when CONFIG_SND_DEBUG=y. the compile is ok but > it won't work, as long as you leave snd_magic_cast. sorry, i overlooked the patch 8/8. but i don't see no reason to leave only snd_magic_cast. if there is no cast checking facility, we should remove them all. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/