Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266130AbUFJFtz (ORCPT ); Thu, 10 Jun 2004 01:49:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266115AbUFJFtz (ORCPT ); Thu, 10 Jun 2004 01:49:55 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:6881 "EHLO ganesha.gnumonks.org") by vger.kernel.org with ESMTP id S263204AbUFJFtv (ORCPT ); Thu, 10 Jun 2004 01:49:51 -0400 Date: Thu, 10 Jun 2004 07:46:24 +0200 From: Harald Welte To: Chris Wedgwood Cc: "David S. Miller" , Alex Williamson , clameter@sgi.com, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184 Message-ID: <20040610054624.GL11490@sunbeam.de.gnumonks.org> References: <1086805676.4288.16.camel@tdi> <20040609130001.37a88da1.davem@redhat.com> <20040610014519.GA3158@taniwha.stupidest.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOmey7/79ja+7F5w" Content-Disposition: inline In-Reply-To: <20040610014519.GA3158@taniwha.stupidest.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-Spam-Score: -4.9 (----) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1963 Lines: 53 --BOmey7/79ja+7F5w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2004 at 06:45:19PM -0700, Chris Wedgwood wrote: > On Wed, Jun 09, 2004 at 01:00:01PM -0700, David S. Miller wrote: >=20 > > How can you legitimately change this structure? It's an exported > > userland interface, if you change it all the applications will stop > > working. >=20 > Why not split the structure for user-space and kernel-space version > and cp/frob at/near the syscall boundary? because it would look like an ugly hack in the setsockopt call, plus adding another costly/time consuming parse of the table BLOB. =20 Also note that the kernel currently has no code that supports the generation/modification of rulesets. All it can do is iterate over them. > --cw --=20 - Harald Welte http://www.netfilter.org/ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie --BOmey7/79ja+7F5w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAx/WwXaXGVTD0i/8RAjesAKCZvTwXcJ1JV9yuVzPfa0sTEFy7OgCeJWpM 2PJ7uaS2rCOHIT1SEuk5EjU= =osOF -----END PGP SIGNATURE----- --BOmey7/79ja+7F5w-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/