Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262972AbUFJUJ7 (ORCPT ); Thu, 10 Jun 2004 16:09:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262954AbUFJUJe (ORCPT ); Thu, 10 Jun 2004 16:09:34 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:41677 "EHLO atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP id S262951AbUFJUJ2 (ORCPT ); Thu, 10 Jun 2004 16:09:28 -0400 Date: Thu, 10 Jun 2004 22:08:25 +0200 From: Pavel Machek To: Herbert Xu Cc: Pavel Machek , mochel@digitalimplant.org, linux-kernel@vger.kernel.org, akpm@zip.com.au Subject: Re: Fix memory leak in swsusp Message-ID: <20040610200824.GH4507@openzaurus.ucw.cz> References: <20040609130451.GA23107@elf.ucw.cz> <20040610105629.GA367@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040610105629.GA367@gondor.apana.org.au> User-Agent: Mutt/1.3.27i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 22 Hi! > > @@ -803,32 +804,31 @@ > > return 0; > > } > > > > + err = -ENOMEM; > > while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order))) { > > memset(m, 0, PAGE_SIZE); > > BTW, what does this memset do? Someone (me?) was trying to be carefull, and was not carefull enough. AFAICS it should be memset(..., PAGE_SIZE << pagedir_order) -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/