Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263766AbUFKJtD (ORCPT ); Fri, 11 Jun 2004 05:49:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263775AbUFKJtD (ORCPT ); Fri, 11 Jun 2004 05:49:03 -0400 Received: from gprs214-150.eurotel.cz ([160.218.214.150]:27776 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S263766AbUFKJtA (ORCPT ); Fri, 11 Jun 2004 05:49:00 -0400 Date: Fri, 11 Jun 2004 11:48:44 +0200 From: Pavel Machek To: Herbert Xu Cc: mochel@digitalimplant.org, linux-kernel@vger.kernel.org, akpm@zip.com.au Subject: Re: Fix memory leak in swsusp Message-ID: <20040611094844.GC13834@elf.ucw.cz> References: <20040609130451.GA23107@elf.ucw.cz> <20040610105629.GA367@gondor.apana.org.au> <20040610212448.GD6634@elf.ucw.cz> <20040610233707.GA4741@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040610233707.GA4741@gondor.apana.org.au> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.5.1+cvs20040105i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 28 Hi! > > > > @@ -803,32 +804,31 @@ > > > > return 0; > > > > } > > > > > > > > + err = -ENOMEM; > > > > while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order))) { > > > > memset(m, 0, PAGE_SIZE); > > > > > > BTW, what does this memset do? > > > > Here's incremental fix, it compiles but not tested. > > Thanks, but my question remains: why do we need the memset? The > area allocated is either thrown away because it collides or is > overwritten with the pagedir stuff straight away. You are right, it should not be needed. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/