Date: Fri, 11 Jun 2004 15:19:18 -0700
From: Andrew Morton <akpm@osdl.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] s390: speedup strn{cpy,len}_from_user.
Message-Id: <20040611151918.00f47792.akpm@osdl.org>
In-Reply-To: <20040611173204.GB3279@mschwid3.boeblingen.de.ibm.com>
References: <20040611173204.GB3279@mschwid3.boeblingen.de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 31

Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
>
> [PATCH] s390: speedup strn{cpy,len}_from_user.
> 
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
> 
> Speedup strncpy_from_user and strnlen_from_user by using
> the search string instruction in the secondary space mode.

There were a few conflicts with Arnd's sparse annotation, which I fixed up.
Please check that next the -mm has it all right.

>  static inline long
>  strncpy_from_user(char *dst, const char *src, long count)
>  {
>          long res = -EFAULT;
>          might_sleep();
> -        if (access_ok(VERIFY_READ, src, 1))
> -                res = __strncpy_from_user_asm(dst, src, count);
> +        if (access_ok(VERIFY_READ, src, 1)) {
> +                res = __strncpy_from_user_asm(count, dst, src);
> +	}
>          return res;
>  }

Shouldn't the access_ok() check be passed `count', rather than `1'?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/