Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264937AbUFLWJa (ORCPT ); Sat, 12 Jun 2004 18:09:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264939AbUFLWJa (ORCPT ); Sat, 12 Jun 2004 18:09:30 -0400 Received: from mail.tpgi.com.au ([203.12.160.113]:33694 "EHLO mail.tpgi.com.au") by vger.kernel.org with ESMTP id S264937AbUFLWIm (ORCPT ); Sat, 12 Jun 2004 18:08:42 -0400 Message-ID: <40CB7F09.6030301@linuxmail.org> Date: Sun, 13 Jun 2004 08:09:13 +1000 From: Nigel Cunningham User-Agent: Mozilla Thunderbird 0.6 (X11/20040502) X-Accept-Language: en-us, en MIME-Version: 1.0 To: pavel@ucw.cz CC: Herbert Xu , Pavel Machek , Patrick Mochel , kernel list , akpm@zip.com.au Subject: Re: Fix memory leak in swsusp References: <20040612084708.23965272BA@smtp.etmail.cz> In-Reply-To: <20040612084708.23965272BA@smtp.etmail.cz> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-TPG-Antivirus: Not scanned Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 607 Lines: 17 pavel@ucw.cz wrote: > At this point it is okay to memcpy - it is copying pagedir, at that point we are outside any critical session. --p Ah. So you're not doing the atomic copy in this routine? Humble apologies. Nigel -- Nigel & Michelle Cunningham C/- Westminster Presbyterian Church Belconnen 61 Templeton Street, Cook, ACT 2614. +61 (417) 100 574 (mobile) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/