Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265224AbUFMRN5 (ORCPT ); Sun, 13 Jun 2004 13:13:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265226AbUFMRNC (ORCPT ); Sun, 13 Jun 2004 13:13:02 -0400 Received: from gate.crashing.org ([63.228.1.57]:9923 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S265224AbUFMRMc (ORCPT ); Sun, 13 Jun 2004 13:12:32 -0400 Subject: Re: [PATCH] Fix ppc64 out_be64 From: Benjamin Herrenschmidt To: Anton Blanchard Cc: Roland Dreier , linuxppc64-dev , Linux Kernel list In-Reply-To: <20040613162150.GA25389@krispykreme> References: <521xkk77xh.fsf@topspin.com> <1087141822.8210.176.camel@gaston> <20040613162150.GA25389@krispykreme> Content-Type: text/plain Message-Id: <1087146513.8556.180.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 13 Jun 2004 12:08:34 -0500 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 22 On Sun, 2004-06-13 at 11:21, Anton Blanchard wrote: > Hi, > > > Ugh ? The syntax of std is std rS, ds(rA), so your fix doesn't look > > good to me, and it definitely builds with the current syntax, though I > > agree the type is indeed wrong. I also spotted another bug where we > > forgot to change an eieio into sync in there though. > > > > Does this totally untested patch works for you ? > > It would be nice to make val unsigned long too :) Ooops... that what happens with patches written before breakfast ;) Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/