Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262279AbUFNJ6i (ORCPT ); Mon, 14 Jun 2004 05:58:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262238AbUFNJ6i (ORCPT ); Mon, 14 Jun 2004 05:58:38 -0400 Received: from [213.146.154.40] ([213.146.154.40]:21203 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262208AbUFNJ6g (ORCPT ); Mon, 14 Jun 2004 05:58:36 -0400 Date: Mon, 14 Jun 2004 10:58:35 +0100 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IDE update for 2.6.7-rc3 [1/12] Message-ID: <20040614095835.GA11585@infradead.org> Mail-Followup-To: Christoph Hellwig , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <200406111750.30312.bzolnier@elka.pw.edu.pl> <20040612103453.GB26482@infradead.org> <200406131936.08338.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406131936.08338.bzolnier@elka.pw.edu.pl> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 18 On Sun, Jun 13, 2004 at 07:36:08PM +0200, Bartlomiej Zolnierkiewicz wrote: > > IMHO the PCI ->probe methods should always be __devinit. It's rather > > hard to make sure they're never every hotplugged in any way, especially > > with the dynamic id adding via sysfs thing. > > I generally agree but IMO it makes no sense for i.e. piix.c. Are you sure? I've seen piix3/4 in very strange place, iirc even in a docking station which is hotpluggable. And even if for this special hardware it's usually not doable there are things like greg's fake hotplug pci driver. So a non-__devinit pci probe method is a bug, please fix them in PCI. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/