Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262538AbUFNLzc (ORCPT ); Mon, 14 Jun 2004 07:55:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262547AbUFNLzc (ORCPT ); Mon, 14 Jun 2004 07:55:32 -0400 Received: from holomorphy.com ([207.189.100.168]:160 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S262538AbUFNLza (ORCPT ); Mon, 14 Jun 2004 07:55:30 -0400 Date: Mon, 14 Jun 2004 04:54:46 -0700 From: William Lee Irwin III To: Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: 2.6.7-rc3-mm2 Message-ID: <20040614115446.GD1444@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org References: <20040614021018.789265c4.akpm@osdl.org> <20040614111540.GB1444@holomorphy.com> <20040614115004.GA16054@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040614115004.GA16054@infradead.org> User-Agent: Mutt/1.5.5.1+cvs20040105i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 35 On Mon, Jun 14, 2004 at 04:15:40AM -0700, William Lee Irwin III wrote: >> The arrangement of the #include in list.h breaks the >> build of documentation. The following patch moves the include to where >> it no longer interferes with kerneldoc's operation. On Mon, Jun 14, 2004 at 12:50:04PM +0100, Christoph Hellwig wrote: > BUG_ON is in , no need to pull in all the crap from kernel.h Revised patch, then: Index: debian-2.6.7-rc3/include/linux/list.h =================================================================== --- debian-2.6.7-rc3.orig/include/linux/list.h 2004-06-14 03:18:03.000000000 -0700 +++ debian-2.6.7-rc3/include/linux/list.h 2004-06-14 04:06:36.000000000 -0700 @@ -5,6 +5,7 @@ #include #include +#include /* BUG_ON */ #include /* @@ -158,7 +159,6 @@ * Note: list_empty on entry does not return true after this, the entry is * in an undefined state. */ -#include /* BUG_ON */ static inline void list_del(struct list_head *entry) { BUG_ON(entry->prev->next != entry); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/