Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263001AbUFNNcU (ORCPT ); Mon, 14 Jun 2004 09:32:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263003AbUFNNcU (ORCPT ); Mon, 14 Jun 2004 09:32:20 -0400 Received: from web41013.mail.yahoo.com ([66.218.93.12]:43886 "HELO web41013.mail.yahoo.com") by vger.kernel.org with SMTP id S263001AbUFNNcT (ORCPT ); Mon, 14 Jun 2004 09:32:19 -0400 Message-ID: <20040614133218.53174.qmail@web41013.mail.yahoo.com> Date: Mon, 14 Jun 2004 06:32:18 -0700 (PDT) From: John Carlson Subject: [PATCH] Usb gadget drivers 2.4 kernel To: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 41 While developing a gadget driver for the 2.4 kernel, I discovered this error in the gadget driver. This bug has been present since the gadget driver was back ported from the 2.6 kernel. diff -urN linux-2.4.27-pre5/drivers/usb/gadget/config.c linux-2.4.27-test/drivers/usb/gadget/config.c --- linux-2.4.27-pre5/drivers/usb/gadget/config.c 2004-06-14 09:06:48.000000000 -0400 +++ linux-2.4.27-test/drivers/usb/gadget/config.c 2004-06-14 09:13:02.000000000 -0400 @@ -51,7 +51,7 @@ for (; 0 != *src; src++) { unsigned len = (*src)->bLength; - if (len > buflen); + if (len > buflen) return -EINVAL; memcpy(dest, *src, len); buflen -= len; John Carlson __________________________________ Do you Yahoo!? Friends. Fun. Try the all-new Yahoo! Messenger. http://messenger.yahoo.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/