Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265953AbUFOVeA (ORCPT ); Tue, 15 Jun 2004 17:34:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265971AbUFOVeA (ORCPT ); Tue, 15 Jun 2004 17:34:00 -0400 Received: from delerium.kernelslacker.org ([81.187.208.145]:62110 "EHLO delerium.codemonkey.org.uk") by vger.kernel.org with ESMTP id S265953AbUFOVd7 (ORCPT ); Tue, 15 Jun 2004 17:33:59 -0400 Date: Tue, 15 Jun 2004 22:33:30 +0100 From: Dave Jones To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" , Dave Jones Subject: Re: [PATCH] Very Trivial - make "After * identify, caps:" messages line up Message-ID: <20040615213330.GA6471@redhat.com> Mail-Followup-To: Dave Jones , Jesper Juhl , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Dave Jones References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 23 On Tue, Jun 15, 2004 at 11:21:44PM +0200, Jesper Juhl wrote: > Visually it's much easier to read/compare messages such as these > > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000 > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000 > > if the numbers line up like this > > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000 > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000 I think it's pointless whilst the third 'after all inits' printk remains a) unindented and b) interrupted by other blurb, but in all honesty, I don't think it really matters, so I won't object either way if it goes in. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/