Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266471AbUFQMt7 (ORCPT ); Thu, 17 Jun 2004 08:49:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266475AbUFQMt7 (ORCPT ); Thu, 17 Jun 2004 08:49:59 -0400 Received: from [213.146.154.40] ([213.146.154.40]:9387 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S266471AbUFQMt6 (ORCPT ); Thu, 17 Jun 2004 08:49:58 -0400 Date: Thu, 17 Jun 2004 13:49:57 +0100 From: Christoph Hellwig To: Takao Indoh Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4]Diskdump Update Message-ID: <20040617124957.GA31392@infradead.org> Mail-Followup-To: Christoph Hellwig , Takao Indoh , linux-kernel@vger.kernel.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 10 my old comments for this are still valid, please add the actual dumping methods directly to scsi_host_template instead of a pointer to another method vector, please make it not a module of it's own but part of the scsi code, please don't use "scsi.h" in new code, and the find gendisk by dev_t code in sd.c is still no good. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/