Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 12 Apr 2001 16:22:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 12 Apr 2001 16:22:04 -0400 Received: from smtpnotes.altec.com ([209.149.164.10]:45581 "HELO smtpnotes.altec.com") by vger.kernel.org with SMTP id ; Thu, 12 Apr 2001 16:21:55 -0400 X-Lotus-FromDomain: ALTEC From: Wayne.Brown@altec.com To: Christoph Hellwig cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com Message-ID: <86256A2C.006FD5D5.00@smtpnotes.altec.com> Date: Thu, 12 Apr 2001 15:21:34 -0500 Subject: Re: badly punctuated parameter list in `#define' (2.4.3-ac5 and 2 .4.4 -pre2) Mime-Version: 1.0 Content-type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Drat, I just noticed my #$@%&$ email program word-wrapped some of the long lines. The four lines that contain just while(0) should be appended (preceded by a space) to the lines just previous to them. Wayne Christoph Hellwig on 04/12/2001 03:16:38 PM To: Wayne Brown/Corporate/Altec@Altec cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com Subject: Re: badly punctuated parameter list in `#define' (2.4.3-ac5 and 2 .4.4 -pre2) On Thu, Apr 12, 2001 at 03:08:28PM -0500, Wayne.Brown@altec.com wrote: > >old compiler. The right ifdef seems to be: > > > > > #if __GNUC__ == 2 && __GNUC_MINOR__ < 95 > > > >Could you test it this way? > > Yes, that works for me. Is this the sort of thing you had in mind? Yes. Linus any chance to apply the following patch? Christoph > > Wayne > > > --- include/asm-i386/rwsem.h.old Thu Apr 12 14:50:08 2001 > +++ include/asm-i386/rwsem.h Thu Apr 12 14:54:14 2001 > @@ -20,18 +20,24 @@ > #include > #include > > +#if __GNUC__ == 2 && __GNUC_MINOR__ < 95 > + > +/* old gcc */ > #if RWSEM_DEBUG > -#define rwsemdebug(FMT,...) do { if (sem->debug) printk(FMT,__VA_ARGS__); } > while(0) > +#define rwsemdebug(FMT, ARGS...) do { if (sem->debug) printk(FMT,##ARGS); } > while(0) > #else > -#define rwsemdebug(FMT,...) > +#define rwsemdebug(FMT, ARGS...) > #endif > > -/* old gcc */ > +#else > + > #if RWSEM_DEBUG > -//#define rwsemdebug(FMT, ARGS...) do { if (sem->debug) printk(FMT,##ARGS); } > while(0) > +#define rwsemdebug(FMT,...) do { if (sem->debug) printk(FMT,__VA_ARGS__); } > while(0) > #else > -//#define rwsemdebug(FMT, ARGS...) > +#define rwsemdebug(FMT,...) > #endif > + > +#endif /* __GNUC__ == 2 && __GNUC_MINOR__ < 95 */ > > #ifdef CONFIG_X86_XADD > #include /* use XADD based semaphores if possible */ > ---end quoted text--- -- Of course it doesn't work. We've performed a software upgrade. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/