Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266737AbUFRSoo (ORCPT ); Fri, 18 Jun 2004 14:44:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266724AbUFRSka (ORCPT ); Fri, 18 Jun 2004 14:40:30 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:33785 "EHLO mail.asahi-net.or.jp") by vger.kernel.org with ESMTP id S266152AbUFRSgT (ORCPT ); Fri, 18 Jun 2004 14:36:19 -0400 Message-ID: <40D3361B.5020304@ThinRope.net> Date: Sat, 19 Jun 2004 03:36:11 +0900 From: Kalin KOZHUHAROV User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040121 X-Accept-Language: bg, en, ja, ru, de MIME-Version: 1.0 To: yoshfuji@linux-ipv6.org Cc: andrew@walrond.org, linux-kernel@vger.kernel.org, netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org Subject: Re: Iptables-1.2.9/10 compile failure with linux 2.6.7 headers References: <40D313DC.7000202@blue-labs.org> <200406181721.47968.andrew@walrond.org> <40D31EA6.5030207@ThinRope.net> <20040619.021818.04202102.yoshfuji@linux-ipv6.org> In-Reply-To: <20040619.021818.04202102.yoshfuji@linux-ipv6.org> X-Enigmail-Version: 0.83.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5023 Lines: 121 YOSHIFUJI Hideaki wrote: > In article <40D31EA6.5030207@ThinRope.net> (at Sat, 19 Jun 2004 01:56:06 +0900), Kalin KOZHUHAROV says: > > >>Yes, I confirm with linux-2.6.7 and iptables-1.2.9 I got: >>gcc -march=athlon-xp -m3dnow -msse -mfpmath=sse -mmmx -O3 -pipe -Iinclude -Wall -Wunused -I/usr/src/linux/include -DIPTABLES_VERSION=\"1.2.9\" -fPIC -o extensions/libipt_stealth_sh.o -c extensions/libipt_stealth.c >>distcc[6323] ERROR: compile on localhost failed >>In file included from include/libiptc/libiptc.h:6, >> from include/iptables.h:5, >> from extensions/libipt_stealth.c:10: >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:255: warning: no semicolon at end of struct or union >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:255: error: syntax error before '*' token >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:259: error: syntax error before '}' token >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: type defaults to `int' in declaration of `DECLARE_MUTEX' >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: parameter names (without types) in function declaration >>/usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: `DECLARE_MUTEX' declared `static' but never defined >>make: *** [extensions/libipt_stealth_sh.o] Error 1 >> >>Last time I recompiled it with 2.6.6 it was ok. The compiled version still seems to work with 2.6.7 for now. > > > Please try this. Thanks > > ===== include/linux/netfilter.h 1.9 vs edited ===== > --- 1.9/include/linux/netfilter.h 2004-06-07 12:15:03 +09:00 > +++ edited/include/linux/netfilter.h 2004-06-19 02:10:55 +09:00 > @@ -10,6 +10,7 @@ > #include > #include > #endif > +#include > > /* Responses from hook functions. */ > #define NF_DROP 0 > ===== include/linux/netfilter_arp/arp_tables.h 1.3 vs edited ===== > --- 1.3/include/linux/netfilter_arp/arp_tables.h 2004-06-04 09:52:00 +09:00 > +++ edited/include/linux/netfilter_arp/arp_tables.h 2004-06-19 02:08:09 +09:00 > @@ -16,7 +16,7 @@ > #include > #include > #endif > - > +#include > #include > > #define ARPT_FUNCTION_MAXNAMELEN 30 > ===== include/linux/netfilter_ipv4/ip_tables.h 1.7 vs edited ===== > --- 1.7/include/linux/netfilter_ipv4/ip_tables.h 2004-06-07 12:15:03 +09:00 > +++ edited/include/linux/netfilter_ipv4/ip_tables.h 2004-06-19 02:08:39 +09:00 > @@ -22,6 +22,7 @@ > #include > #include > #endif > +#include > #include > > #define IPT_FUNCTION_MAXNAMELEN 30 > @@ -336,8 +337,8 @@ > /* > * Main firewall chains definitions and global var's definitions. > */ > -static DECLARE_MUTEX(ipt_mutex); > #ifdef __KERNEL__ > +static DECLARE_MUTEX(ipt_mutex); > > #include > extern void ipt_init(void) __init; > ===== include/linux/netfilter_ipv6/ip6_tables.h 1.6 vs edited ===== > --- 1.6/include/linux/netfilter_ipv6/ip6_tables.h 2004-06-07 12:15:04 +09:00 > +++ edited/include/linux/netfilter_ipv6/ip6_tables.h 2004-06-19 02:09:29 +09:00 > @@ -22,6 +22,7 @@ > #include > #include > #endif > +#include > #include > > #define IP6T_FUNCTION_MAXNAMELEN 30 > @@ -106,7 +107,9 @@ > u_int64_t pcnt, bcnt; /* Packet and byte counters */ > }; > > +#ifdef __KERNEL__ > static DECLARE_MUTEX(ip6t_mutex); > +#endif > > /* Values for "flag" field in struct ip6t_ip6 (general ip6 structure). */ > #define IP6T_F_PROTO 0x01 /* Set if rule cares about upper > As far as I understand from this patch, this should be applied to the system headers... I thought `diff -Nru A B` was the format of choice in LKML... Anyway, thank you for the patch, but I am not thinking to patch linux-headers, as I like to refer to them as something more or less stable (As opposed to the current kernel). And just out of curiosity, I did: include $ patch --dry-run -p2 WWW: http://ThinRope.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/