Subject: Re: DMA API issues
From: James Bottomley <James.Bottomley@steeleye.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jamey Hicks <jamey.hicks@hp.com>, Ian Molton <spyro@f2s.com>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Greg KH <greg@kroah.com>, tony@atomide.com,
       David Brownell <david-b@pacbell.net>, joshua@joshuawise.com
In-Reply-To: <1087589651.8210.288.camel@gaston>
References: <1087582845.1752.107.camel@mulgrave>
	<20040618193544.48b88771.spyro@f2s.com>
	<1087584769.2134.119.camel@mulgrave>  <40D340FB.3080309@hp.com> 
	<1087589651.8210.288.camel@gaston>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 18 Jun 2004 15:24:45 -0500
Message-Id: <1087590286.2135.161.camel@mulgrave>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 962
Lines: 24

On Fri, 2004-06-18 at 15:14, Benjamin Herrenschmidt wrote:
> I wanted to do just that a while ago, and ended up doing things a bit
> differently, but still, I agree that would help. The thing is, you
> can do that in your platform code. just use the platform data pointer
> in struct device to stuff a ptr to the structure with your "ops"

Yes, we do this on parisc too.  We actually have a hidden method pointer
(per platform) and cache the iommu (we have more than one) accessors in
platform_data.

The problem is, though, that I really don't think this interface would
benefit from being made public (or part of the API).  There are too many
nasty quirks in the platform for this (at least in our case).

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/