From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] Add kallsyms_lookup() result cache
Date: Fri, 18 Jun 2004 19:26:39 -0400
User-Agent: KMail/1.6.2
Cc: Brent Casavant <bcasavan@sgi.com>, linux-kernel@vger.kernel.org,
       rusty@rustcorp.com.au
References: <Pine.SGI.4.58.0406181435570.5029@kzerza.americas.sgi.com> <20040619000326.067c3ff6.ak@suse.de>
In-Reply-To: <20040619000326.067c3ff6.ak@suse.de>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200406181926.39294.jbarnes@engr.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1081
Lines: 29

On Friday, June 18, 2004 6:03 pm, Andi Kleen wrote:
> On Fri, 18 Jun 2004 15:03:00 -0500
>
> Brent Casavant <bcasavan@sgi.com> wrote:
> > On 2.6 based systems, the top command utilizes /proc/[pid]/wchan to
> > determine WCHAN symbol name information.  This information is provided
> > by the kernel function kallsyms_lookup(), which expands a stem-compressed
>
> That sounds more like a bug in your top to me. /proc/*/wchan itself
> does not access kallsyms, it just outputs a number.undisclosed-recipients:;

No, it outputs a string:
jbarnes@mill:~$ cat /proc/1/wchan
do_select

I haven't looked, but it's probably dependent on CONFIG_KALLSYMS.

> Doing the cache in the kernel is the wrong place. This should be fixed
> in user space.

Sure, but that would be a change in behavior.  It's arguably the right thing 
to do though.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/