Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265305AbUFSJ2L (ORCPT ); Sat, 19 Jun 2004 05:28:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265314AbUFSJ2L (ORCPT ); Sat, 19 Jun 2004 05:28:11 -0400 Received: from witte.sonytel.be ([80.88.33.193]:25080 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S265305AbUFSJ2J (ORCPT ); Sat, 19 Jun 2004 05:28:09 -0400 Date: Sat, 19 Jun 2004 11:28:00 +0200 (MEST) From: Geert Uytterhoeven To: Antonino Daplas cc: Jakub Bogusz , Linux Kernel Development , Linux Frame Buffer Device Development , pld-kernel@pld-linux.org Subject: Re: [Linux-fbdev-devel] 2.6.7 fbcon: set_con2fb on current console = crash In-Reply-To: <200406191413.44439.adaplas@hotpop.com> Message-ID: References: <20040618215047.GA4723@satan.blackhosts> <200406191413.44439.adaplas@hotpop.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 25 On Sat, 19 Jun 2004, Antonino A. Daplas wrote: > Thanks. Actually there's still a critical flaw in the set_con2fbmap code. > For one, con2fb_map is never initialized. It's just fortunate that this > array happens to be filled with zeroes so con2fb_map[n] will always return > zero and registered_fb[0] happens to contain a valid info. So it works, by > accident. According to the C standard, global variables are initialized to zero, unless specified otherwise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/