Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265341AbUFSJpR (ORCPT ); Sat, 19 Jun 2004 05:45:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265323AbUFSJpR (ORCPT ); Sat, 19 Jun 2004 05:45:17 -0400 Received: from fw.osdl.org ([65.172.181.6]:58283 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S265341AbUFSJpO (ORCPT ); Sat, 19 Jun 2004 05:45:14 -0400 Date: Sat, 19 Jun 2004 02:44:16 -0700 From: Andrew Morton To: Keith Owens Cc: linux-kernel@vger.kernel.org Subject: Re: [patch 2.6.7] bug_smp_call_function Message-Id: <20040619024416.065f4026.akpm@osdl.org> In-Reply-To: <5328.1087637808@kao2.melbourne.sgi.com> References: <5328.1087637808@kao2.melbourne.sgi.com> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 16 Keith Owens wrote: > > sg.c has been fixed to no longer call vfree() with interrupts disabled. > Change smp_call_function() from WARN_ON to BUG_ON when interrupts are > disabled. It was only set to WARN_ON because of sg.c. I prefer the WARN_ON. It is exceedingly unlikely that the bug will cause lockups or memory/data corruption or anything else, so why nuke the user's box when we can trivially continue? We'll be sent the bug report either way. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/