Subject: Re: [PATCH] Stop printk printing non-printable chars
From: David Woodhouse <dwmw2@infradead.org>
To: matthew-lkml@newtoncomputing.co.uk
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
In-Reply-To: <20040618205355.GA5286@newtoncomputing.co.uk>
References: <20040618205355.GA5286@newtoncomputing.co.uk>
Content-Type: text/plain
Message-Id: <1087643904.5494.7.camel@imladris.demon.co.uk>
Mime-Version: 1.0
Date: Sat, 19 Jun 2004 12:18:24 +0100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1012
Lines: 26

On Fri, 2004-06-18 at 21:53 +0100, matthew-lkml@newtoncomputing.co.uk
wrote:
> The main problem seems to be in ACPI, but I don't see any reason for
> printk to even consider printing _any_ non-printable characters at all.
> It makes all characters out of the range 32..126 (except for newline)
> print as a '?'.

Please don't do that -- it makes printing UTF-8 impossible. While I'd
not argue that now is the time to start outputting UTF-8 all over the
place, I wouldn't accept that it's a good time to _prevent_ it either,
as your patch would do.

If you want to post-process printk output, don't do it in the kernel. 

I'd suggest that in this instance you should be fixing the ACPI code
instead, so it doesn't print the characters to which you object.

-- 
dwmw2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/