Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265661AbUFSMba (ORCPT ); Sat, 19 Jun 2004 08:31:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265685AbUFSMb3 (ORCPT ); Sat, 19 Jun 2004 08:31:29 -0400 Received: from mail.dif.dk ([193.138.115.101]:7905 "EHLO mail.dif.dk") by vger.kernel.org with ESMTP id S265661AbUFSMb2 (ORCPT ); Sat, 19 Jun 2004 08:31:28 -0400 Date: Sat, 19 Jun 2004 14:30:32 +0200 (CEST) From: Jesper Juhl To: John Cherry Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , James Simmons , Linux Frame Buffer Device Development Subject: Fix warning in tdfxfb.c (Was: Re: IA32 (2.6.7 - 2004-06-18.22.30) - 2 New warnings (gcc 3.2.2)) In-Reply-To: <200406191135.i5JBZsXL017823@cherrypit.pdx.osdl.net> Message-ID: References: <200406191135.i5JBZsXL017823@cherrypit.pdx.osdl.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 32 On Sat, 19 Jun 2004, John Cherry wrote: > drivers/video/tdfxfb.c:1104: warning: initialization discards qualifiers from pointer target type Here's a patch for that. The issue is that the mask member of struct fb_cursor is const, so we shouldn't be assigning it to a non-const char* Signed-off-by: Jesper Juhl --- linux-2.6.7-orig/drivers/video/tdfxfb.c 2004-06-16 07:19:02.000000000 +0200 +++ linux-2.6.7/drivers/video/tdfxfb.c 2004-06-19 14:25:16.000000000 +0200 @@ -1101,7 +1101,7 @@ static int tdfxfb_cursor(struct fb_info */ u8 *cursorbase = (u8 *) info->cursor.image.data; char *bitmap = (char *)cursor->image.data; - char *mask = cursor->mask; + const char *mask = cursor->mask; int i, j, k, h = 0; for (i = 0; i < 64; i++) { -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/