Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261914AbUFSO0G (ORCPT ); Sat, 19 Jun 2004 10:26:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262388AbUFSO0G (ORCPT ); Sat, 19 Jun 2004 10:26:06 -0400 Received: from rwcrmhc13.comcast.net ([204.127.198.39]:58314 "EHLO rwcrmhc13.comcast.net") by vger.kernel.org with ESMTP id S261914AbUFSO0D (ORCPT ); Sat, 19 Jun 2004 10:26:03 -0400 Subject: Re: [PATCH] Add kallsyms_lookup() result cache From: Albert Cahalan To: Herbert Xu Cc: linux-kernel mailing list , ak@suse.de, bcasavan@sgi.com In-Reply-To: References: Content-Type: text/plain Organization: Message-Id: <1087646624.8188.852.camel@cube> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 19 Jun 2004 08:03:45 -0400 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 27 On Sat, 2004-06-19 at 00:51, Herbert Xu wrote: > Albert Cahalan wrote: > > > >> Are you saying your top reads /proc/kallsyms on each redisplay? > >> That sounds completely wrong - it should only read the file once > >> and cache it and then look the numbers it is reading from wchan > >> in the cache. > >> > >> Doing the cache in the kernel is the wrong place. This should be fixed > >> in user space. > > > > No way, because: > > > > 1. kernel modules may be loaded or unloaded at any time > > We seem to have coped alright under 2.4. Not really. We coped alright long ago. Things were getting worse year by year, with modules becoming more popular and their symbols not 100% exported. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/